Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BCI-2953] Initial Aptos keystore #13564

Merged
merged 65 commits into from
Jul 2, 2024
Merged

[BCI-2953] Initial Aptos keystore #13564

merged 65 commits into from
Jul 2, 2024

Conversation

yongkangchia
Copy link
Contributor

@yongkangchia yongkangchia commented Jun 15, 2024

Ticket

BCI-2953

Changes:

  • Added Aptos Keystore to Core. This includes Aptos Key which uses ED25519, Keystore, Relevant tests

Note:

  • Config Related changes are pushed to Another ticket as Aptos is still in development stages. Config changes can be made when ready.

core/services/keystore/keys/aptoskey/key.go Fixed Show fixed Hide fixed
core/services/keystore/aptos.go Fixed Show fixed Hide fixed
core/services/keystore/models.go Fixed Show fixed Hide fixed
core/services/keystore/keys/aptoskey/key.go Dismissed Show dismissed Hide dismissed
@yongkangchia yongkangchia marked this pull request as ready for review June 18, 2024 09:59
@yongkangchia yongkangchia requested review from a team as code owners June 18, 2024 09:59
@yongkangchia yongkangchia changed the title BCI-2953: Add Aptos keystore BCI-2953: Initial Aptos keystore Jun 18, 2024
@yongkangchia yongkangchia marked this pull request as draft June 18, 2024 10:25
@archseer
Copy link
Contributor

Don't forget to include

case types.NetworkAptos:
// TODO BCI-2953
return nil
}

Co-authored-by: Jordan Krage <jmank88@gmail.com>
@archseer archseer enabled auto-merge July 2, 2024 01:25
@archseer archseer added this pull request to the merge queue Jul 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 2, 2024
@archseer archseer added this pull request to the merge queue Jul 2, 2024
Merged via the queue into develop with commit 2c2ca6a Jul 2, 2024
112 checks passed
@archseer archseer deleted the BCI-2953-Aptos-Keystore branch July 2, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants