BCF - 3139 Chain Reader Log Poller filters in config and some code cleanup #13356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija42
force-pushed
the
BCF-3139-chreader-lp-filter-config
branch
from
fea446c
to
58c637d
Compare
…lp-filter-config # Conflicts: # core/services/relay/evm/chain_reader.go # core/services/relay/evm/chain_reader_test.go # core/services/relay/evm/event_binding.go # core/services/relay/evm/types/types.go
|
ilija42
force-pushed
the
BCF-3139-chreader-lp-filter-config
branch
from
43368b2
to
474097a
Compare
…lp-filter-config # Conflicts: # core/services/relay/evm/chain_reader_test.go
ilija42
force-pushed
the
BCF-3139-chreader-lp-filter-config
branch
from
e454a7e
to
3acb2c4
Compare
reductionista
approved these changes
Jun 13, 2024
|
LGTM! Nice approach, I think this will work well going forward. |
krehermann
approved these changes
Jun 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related : smartcontractkit/chainlink-common#572