Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCI-1426: Add GasPriceSubunits Data Source Pipeline #13200

Merged
merged 15 commits into from
May 23, 2024
Merged

BCI-1426: Add GasPriceSubunits Data Source Pipeline #13200

merged 15 commits into from
May 23, 2024

Conversation

augustbleeds
Copy link
Contributor

@augustbleeds augustbleeds commented May 14, 2024 •
edited
Loading

Changes

  • Add optional GasPriceSubunits pipeline in the plugin Config
  • Validate the pipeline in ORM (if it exists) before insertion into postgres
  • If gasPriceSubunits data source does not exist, create a zero data source. Pass it to the NewMedianFactory

Merge Order

  1. BCI-1426: Gas Price Subunits Changes chainlink-common#509
  2. Add Gas Price Data Source chainlink-feeds#28
  3. This PR

@augustbleeds augustbleeds requested review from a team as code owners May 14, 2024 22:16
augustbleeds
augustbleeds commented May 14, 2024
View reviewed changes
.tool-versions
@@ -2,7 +2,7 @@ golang 1.21.7
mockery 2.42.2
nodejs 20.13.1
pnpm 8.15.8
postgres 14.11
postgres 15.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overdue for a bump?

This was referenced May 15, 2024
Merged
Merged
krehermann
krehermann reviewed May 16, 2024
View reviewed changes
plugins/medianpoc/plugin.go Outdated
return nil, err
}

// Setting includeGasPriceSubunitsInObservation properly ensures we do not break libocr codec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we had talked about updating this comment to be a more direct and simpler -- we have to omit the field in to maintain backward compatibility

@bolekk
Copy link
Contributor

bolekk commented May 23, 2024

Is this ready to be merged? I'd like to update common dep to latest.

bolekk
bolekk previously approved these changes May 23, 2024
View reviewed changes
jmank88
jmank88 previously approved these changes May 23, 2024
View reviewed changes
@augustbleeds augustbleeds dismissed stale reviews from jmank88 and bolekk via f0923d6 May 23, 2024 19:55
@augustbleeds augustbleeds requested a review from RensR as a code owner May 23, 2024 19:55
@augustbleeds
Copy link
Contributor Author

there was a merge conflict so I had to resolve that. will need approvals again xD @jmank88 @bolekk

@augustbleeds
Copy link
Contributor Author

anyone able to add to merge queue?

@bolekk bolekk enabled auto-merge May 23, 2024 20:46
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
5.11% Technical Debt Ratio on New Code (required ≤ 4%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@bolekk bolekk added this pull request to the merge queue May 23, 2024
Merged via the queue into develop with commit 4718aa7 May 23, 2024
106 of 107 checks passed
@bolekk bolekk deleted the augustus.BCI-1426.gasPriceSubunits-datasource branch May 23, 2024 21:26
This was referenced May 23, 2024
Draft
Draft
@RensR RensR mentioned this pull request May 27, 2024
Merged
augustbleeds added a commit that referenced this pull request Jun 14, 2024
@augustbleeds @bolekk
BCI-1426: Add GasPriceSubunits Data Source Pipeline (#13200)
a7c9ab9 
* initial

* incorporate gasPriceSubunits data source

* update deps

* add in data source

* comment

* update plugin config

* add changeset

* update chainlink-common & chainlink-feeds

* lint fixes

* lint

---------

Co-authored-by: Bolek <1416262+bolekk@users.noreply.github.com>
augustbleeds added a commit that referenced this pull request Jun 14, 2024
@augustbleeds @bolekk
BCI-1426: Add GasPriceSubunits Data Source Pipeline (#13200)
5e28076 
* initial

* incorporate gasPriceSubunits data source

* update deps

* add in data source

* comment

* update plugin config

* add changeset

* update chainlink-common & chainlink-feeds

* lint fixes

* lint

---------

Co-authored-by: Bolek <1416262+bolekk@users.noreply.github.com>
@augustbleeds augustbleeds mentioned this pull request Jun 17, 2024
Merged
augustbleeds added a commit that referenced this pull request Jun 17, 2024
@augustbleeds @bolekk
BCI-1426: Add GasPriceSubunits Data Source Pipeline (#13200)
0115ac1 
* initial

* incorporate gasPriceSubunits data source

* update deps

* add in data source

* comment

* update plugin config

* add changeset

* update chainlink-common & chainlink-feeds

* lint fixes

* lint

---------

Co-authored-by: Bolek <1416262+bolekk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krehermann krehermann krehermann left review comments

@jmank88 jmank88 jmank88 approved these changes

@bolekk bolekk bolekk approved these changes

@george-dorin george-dorin Awaiting requested review from george-dorin

@RensR RensR Awaiting requested review from RensR RensR is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@augustbleeds @bolekk @jmank88 @krehermann