Created a GetFilters function for the logpoller #12621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
| filters := th.LogPoller.GetFilters() | ||
| assert.Equal(t, 3, len(filters)) | ||
| assert.True(t, filters["first Filter"].Name == "first Filter") | ||
| assert.True(t, reflect.DeepEqual(filters["first Filter"].EventSigs, filter1.EventSigs)) |
There was a problem hiding this comment.
You don't need to call reflect.DeepEqual here, that's already called internally by assert.Equal. For example, this should work:
Suggested change
| assert.True(t, reflect.DeepEqual(filters["first Filter"].EventSigs, filter1.EventSigs)) | |
| assert.Equal(t, filter1.EventSigs, filters["first Filter"].EventSigs) |
Actually, all 3 fields could be probably be compared in just one line:
assert.Equal(t, filter1, filters["first Filter"])
But we'd have to add Topic2, Topic3, & Topic4 in the original definition of filter1:
Topic2: evmtypes.HashArray{},
Topic3: evmtypes.HashArray{},
Topic4: evmtypes.HashArray{},
Either way is fine with me
There was a problem hiding this comment.
Thanks! I just decided to use assert.Equal everywhere to remove the use of reflect. I think this should be fine.
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetFilters method should return a full deep copy of the underlying lp.filters mapping with no pointers whatsoever to the original mapping.
This will be used by Functions to facilitate cleaning up old filters for previous contract versions which are no longer in use.
See here for context: https://chainlink-core.slack.com/archives/C03RCTX5RU0/p1711494411843329