Set LINK native feed in VRFV2PlusWrapper to immutable #12592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ibrajer
commented
Mar 26, 2024
ibrajer
commented
- LINK native feed set to immutable, removed setter function
- both LINK token and LINK native feed can be set to zero addresses
- fixed Foundry tests
|
I see you updated files related to |
|
I see you updated files related to |
kidambisrinivas
previously approved these changes
Mar 26, 2024
|
Go solidity wrappers are out-of-date, regenerate them via the |
* LINK native feed set to immutable, removed setter function * both LINK token and LINK native feed can be set to zero addresses * fixed Foundry tests
Co-authored-by: Lee Yik Jiun <yikjiun.lee@smartcontract.com>
ibrajer
force-pushed
the
chore/vrfv2plus-wrapper-immutable-link-native-feed
branch
from
9a189a7
to
4d630f2
Compare
|
Go solidity wrappers are out-of-date, regenerate them via the |
kidambisrinivas
previously approved these changes
Mar 26, 2024
jinhoonbang
reviewed
Mar 26, 2024
| @@ -30,6 +30,7 @@ contract VRFV2PlusWrapper is ConfirmedOwner, TypeAndVersionInterface, VRFConsume | |||
| // solhint-disable-next-line chainlink-solidity/prefix-immutable-variables-with-i | |||
| uint256 public immutable SUBSCRIPTION_ID; | |||
| LinkTokenInterface internal immutable i_link; | |||
| AggregatorV3Interface public immutable i_link_native_feed; | |||
There was a problem hiding this comment.
*nit can be internal right? since there is a new getter below?
|
kidambisrinivas
approved these changes
Mar 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kidambisrinivas
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Set LINK native feed in VRFV2PlusWrapper to immutable * LINK native feed set to immutable, removed setter function * both LINK token and LINK native feed can be set to zero addresses * fixed Foundry tests * Added solhint disable for LINK_NATIVE_FEED immutable var * Added changesets * Delete storage slot padding from VRFV2PlusWrapper Co-authored-by: Lee Yik Jiun <yikjiun.lee@smartcontract.com> * Renamed LINK_NATIVE_FEED to i_link_native_feed, generated Go wrappers * Fixed linter issue * Link native feed address variable set to internal --------- Co-authored-by: Lee Yik Jiun <yikjiun.lee@smartcontract.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.