skip deleted proposals when checking isJobManaged

smartcontractkit · Aug 29, 2024 · 9899dd0 · 9899dd0
1 parent 7c248e7
commit 9899dd0
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/.changeset/tricky-eagles-knock.md b/.changeset/tricky-eagles-knock.md
@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+skip checking isJobManaged if the proposal in fms has already been deleted #changed
diff --git a/core/services/feeds/orm.go b/core/services/feeds/orm.go
@@ -826,6 +826,7 @@ SELECT exists (
 	FROM job_proposals
 	INNER JOIN jobs ON job_proposals.external_job_id = jobs.external_job_id
 	WHERE jobs.id = $1
+	AND job_proposals.status <> 'deleted'
 );
 `
 

diff --git a/core/services/feeds/orm_test.go b/core/services/feeds/orm_test.go
@@ -1653,6 +1653,14 @@ func Test_ORM_IsJobManaged(t *testing.T) {
 	isManaged, err = orm.IsJobManaged(ctx, int64(j.ID))
 	require.NoError(t, err)
 	assert.True(t, isManaged)
+
+	// delete the proposal
+	err = orm.DeleteProposal(ctx, jpID)
+	require.NoError(t, err)
+
+	isManaged, err = orm.IsJobManaged(ctx, int64(j.ID))
+	require.NoError(t, err)
+	assert.False(t, isManaged)
 }
 
 // Helpers