Skip to content

Commit

Permalink
update bumpThresholds for chains using suggestedPrice estimator (#13078)
Browse files Browse the repository at this point in the history
* update bumpThresholds for chains using suggestedPrice estimator

* added changeset

* added changeset

* added tag to changeset

* updated config docs

---------

Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>
  • Loading branch information
finleydecker and prashantkumar1982 committed May 15, 2024
1 parent 1b1e31e commit 0917394
Show file tree
Hide file tree
Showing 13 changed files with 25 additions and 29 deletions.
5 changes: 5 additions & 0 deletions .changeset/silver-birds-wave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": patch
---

bumpThreshold config setting for chains using suggestPrice estimator #updated
3 changes: 1 addition & 2 deletions core/chains/evm/config/toml/defaults/Arbitrum_Goerli.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ PriceMin = '0'
PriceDefault = '0.1 gwei'
PriceMax = '115792089237316195423570985008687907853269984665.640564039457584007913129639935 tether'
FeeCapDefault = '1000 gwei'
# Disable gas bumping on arbitrum
BumpThreshold = 0
BumpThreshold = 5

[GasEstimator.BlockHistory]
# Force an error if someone set GAS_UPDATER_ENABLED=true by accident; we never want to run the block history estimator on arbitrum
Expand Down
3 changes: 1 addition & 2 deletions core/chains/evm/config/toml/defaults/Arbitrum_Mainnet.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ PriceMin = '0'
PriceDefault = '0.1 gwei'
PriceMax = '115792089237316195423570985008687907853269984665.640564039457584007913129639935 tether'
FeeCapDefault = '1000 gwei'
# Disable gas bumping on arbitrum
BumpThreshold = 0
BumpThreshold = 5

[GasEstimator.BlockHistory]
# Force an error if someone set GAS_UPDATER_ENABLED=true by accident; we never want to run the block history estimator on arbitrum
Expand Down
3 changes: 1 addition & 2 deletions core/chains/evm/config/toml/defaults/Arbitrum_Rinkeby.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ PriceMin = '0'
PriceDefault = '0.1 gwei'
PriceMax = '115792089237316195423570985008687907853269984665.640564039457584007913129639935 tether'
FeeCapDefault = '1000 gwei'
# Disable gas bumping on arbitrum
BumpThreshold = 0
BumpThreshold = 5

[GasEstimator.BlockHistory]
# Force an error if someone set GAS_UPDATER_ENABLED=true by accident; we never want to run the block history estimator on arbitrum
Expand Down
3 changes: 1 addition & 2 deletions core/chains/evm/config/toml/defaults/Arbitrum_Sepolia.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ PriceMin = '0'
PriceDefault = '0.1 gwei'
PriceMax = '115792089237316195423570985008687907853269984665.640564039457584007913129639935 tether'
FeeCapDefault = '1000 gwei'
# Disable gas bumping on arbitrum
BumpThreshold = 0
BumpThreshold = 5

[GasEstimator.BlockHistory]
# Force an error if someone set GAS_UPDATER_ENABLED=true by accident; we never want to run the block history estimator on arbitrum
Expand Down
2 changes: 1 addition & 1 deletion core/chains/evm/config/toml/defaults/Klaytn_Mainnet.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ OCR.ContractConfirmations = 1
[GasEstimator]
Mode = 'SuggestedPrice'
PriceDefault = '750 gwei' # gwei = ston
BumpThreshold = 0
BumpThreshold = 5
2 changes: 1 addition & 1 deletion core/chains/evm/config/toml/defaults/Klaytn_Testnet.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ OCR.ContractConfirmations = 1
[GasEstimator]
Mode = 'SuggestedPrice'
PriceDefault = '750 gwei' # gwei = ston
BumpThreshold = 0
BumpThreshold = 5
3 changes: 1 addition & 2 deletions core/chains/evm/config/toml/defaults/Metis_Mainnet.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ OCR.ContractConfirmations = 1
Mode = 'SuggestedPrice'
# Metis uses the SuggestedPrice estimator; we don't want to place any limits on the minimum gas price
PriceMin = '0'
# Never bump gas on metis
BumpThreshold = 0
BumpThreshold = 3

[BalanceMonitor]
Enabled = true
Expand Down
2 changes: 1 addition & 1 deletion core/chains/evm/config/toml/defaults/Metis_Rinkeby.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Enabled = true
[GasEstimator]
Mode = 'SuggestedPrice'
PriceMin = '0'
BumpThreshold = 0
BumpThreshold = 3

[GasEstimator.BlockHistory]
BlockHistorySize = 0
Expand Down
2 changes: 1 addition & 1 deletion core/chains/evm/config/toml/defaults/Metis_Sepolia.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Enabled = true
[GasEstimator]
Mode = 'SuggestedPrice'
PriceMin = '0'
BumpThreshold = 0
BumpThreshold = 3

[GasEstimator.BlockHistory]
BlockHistorySize = 0
Expand Down
2 changes: 0 additions & 2 deletions core/chains/evm/config/toml/defaults/Scroll_Mainnet.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ OCR.ContractConfirmations = 1
Mode = 'SuggestedPrice'
# Scroll uses the SuggestedPrice estimator; we don't want to place any limits on the minimum gas price
PriceMin = '0'
# Never bump gas on Scroll
BumpThreshold = 0

[GasEstimator.BlockHistory]
# Force an error if someone enables the estimator by accident; we never want to run the block history estimator on Scroll
Expand Down
2 changes: 0 additions & 2 deletions core/chains/evm/config/toml/defaults/Scroll_Sepolia.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ OCR.ContractConfirmations = 1
Mode = 'SuggestedPrice'
# Scroll uses the SuggestedPrice estimator; we don't want to place any limits on the minimum gas price
PriceMin = '0'
# Never bump gas on Scroll
BumpThreshold = 0

[GasEstimator.BlockHistory]
# Force an error if someone enables the estimator by accident; we never want to run the block history estimator on Scroll
Expand Down
22 changes: 11 additions & 11 deletions docs/CONFIG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3729,7 +3729,7 @@ LimitMultiplier = '1'
LimitTransfer = 21000
BumpMin = '5 gwei'
BumpPercent = 20
BumpThreshold = 0
BumpThreshold = 3
EIP1559DynamicFees = false
FeeCapDefault = '100 gwei'
TipCapDefault = '1 wei'
Expand Down Expand Up @@ -3813,7 +3813,7 @@ LimitMultiplier = '1'
LimitTransfer = 21000
BumpMin = '5 gwei'
BumpPercent = 20
BumpThreshold = 0
BumpThreshold = 5
EIP1559DynamicFees = false
FeeCapDefault = '100 gwei'
TipCapDefault = '1 wei'
Expand Down Expand Up @@ -3898,7 +3898,7 @@ LimitMultiplier = '1'
LimitTransfer = 21000
BumpMin = '5 gwei'
BumpPercent = 20
BumpThreshold = 0
BumpThreshold = 3
EIP1559DynamicFees = false
FeeCapDefault = '100 gwei'
TipCapDefault = '1 wei'
Expand Down Expand Up @@ -4658,7 +4658,7 @@ LimitMultiplier = '1'
LimitTransfer = 21000
BumpMin = '5 gwei'
BumpPercent = 20
BumpThreshold = 0
BumpThreshold = 5
EIP1559DynamicFees = false
FeeCapDefault = '100 gwei'
TipCapDefault = '1 wei'
Expand Down Expand Up @@ -4914,7 +4914,7 @@ LimitMultiplier = '1'
LimitTransfer = 21000
BumpMin = '5 gwei'
BumpPercent = 20
BumpThreshold = 0
BumpThreshold = 5
EIP1559DynamicFees = false
FeeCapDefault = '1 micro'
TipCapDefault = '1 wei'
Expand Down Expand Up @@ -5591,7 +5591,7 @@ LimitMultiplier = '1'
LimitTransfer = 21000
BumpMin = '5 gwei'
BumpPercent = 20
BumpThreshold = 0
BumpThreshold = 3
EIP1559DynamicFees = false
FeeCapDefault = '100 gwei'
TipCapDefault = '1 wei'
Expand Down Expand Up @@ -6016,7 +6016,7 @@ LimitMultiplier = '1'
LimitTransfer = 21000
BumpMin = '5 gwei'
BumpPercent = 20
BumpThreshold = 0
BumpThreshold = 5
EIP1559DynamicFees = false
FeeCapDefault = '1 micro'
TipCapDefault = '1 wei'
Expand Down Expand Up @@ -6102,7 +6102,7 @@ LimitMultiplier = '1'
LimitTransfer = 21000
BumpMin = '5 gwei'
BumpPercent = 20
BumpThreshold = 0
BumpThreshold = 5
EIP1559DynamicFees = false
FeeCapDefault = '1 micro'
TipCapDefault = '1 wei'
Expand Down Expand Up @@ -6187,7 +6187,7 @@ LimitMultiplier = '1'
LimitTransfer = 21000
BumpMin = '5 gwei'
BumpPercent = 20
BumpThreshold = 0
BumpThreshold = 5
EIP1559DynamicFees = false
FeeCapDefault = '1 micro'
TipCapDefault = '1 wei'
Expand Down Expand Up @@ -6272,7 +6272,7 @@ LimitMultiplier = '1'
LimitTransfer = 21000
BumpMin = '5 gwei'
BumpPercent = 20
BumpThreshold = 0
BumpThreshold = 3
EIP1559DynamicFees = false
FeeCapDefault = '100 gwei'
TipCapDefault = '1 wei'
Expand Down Expand Up @@ -6357,7 +6357,7 @@ LimitMultiplier = '1'
LimitTransfer = 21000
BumpMin = '5 gwei'
BumpPercent = 20
BumpThreshold = 0
BumpThreshold = 3
EIP1559DynamicFees = false
FeeCapDefault = '100 gwei'
TipCapDefault = '1 wei'
Expand Down

0 comments on commit 0917394

Please sign in to comment.