Skip to content

Commit

Permalink
Clear API breakages
Browse files Browse the repository at this point in the history
  • Loading branch information
cescoffier committed Aug 28, 2024
1 parent 5ddeb01 commit fdf8f82
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 56 deletions.
39 changes: 1 addition & 38 deletions microprofile/revapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,44 +24,7 @@
"criticality" : "highlight",
"minSeverity" : "POTENTIALLY_BREAKING",
"minCriticality" : "documented",
"differences" : [
{
"ignore": true,
"code": "java.field.removedWithConstant",
"old": "field io.smallrye.stork.microprofile.MicroProfileConfigProvider.LOAD_BALANCER",
"justification": "Moved to stork-core io.smallrye.stork.utils.StorkConfigUtils.LOAD_BALANCER"
},
{
"ignore": true,
"code": "java.field.removedWithConstant",
"old": "field io.smallrye.stork.microprofile.MicroProfileConfigProvider.LOAD_BALANCER_EMBEDDED",
"justification": "Moved to stork-core io.smallrye.stork.utils.StorkConfigUtils.LOAD_BALANCER_EMBEDDED"
},
{
"ignore": true,
"code": "java.field.removedWithConstant",
"old": "field io.smallrye.stork.microprofile.MicroProfileConfigProvider.SERVICE_DISCOVERY",
"justification": "Moved to stork-core io.smallrye.stork.utils.StorkConfigUtils.SERVICE_DISCOVERY"
},
{
"ignore": true,
"code": "java.field.removedWithConstant",
"old": "field io.smallrye.stork.microprofile.MicroProfileConfigProvider.SERVICE_DISCOVERY_EMBEDDED",
"justification": "Moved to stork-core io.smallrye.stork.utils.StorkConfigUtils.SERVICE_DISCOVERY_EMBEDDED"
},
{
"ignore": true,
"code": "java.field.removedWithConstant",
"old": "field io.smallrye.stork.microprofile.MicroProfileConfigProvider.SERVICE_REGISTRAR",
"justification": "Moved to stork-core io.smallrye.stork.utils.StorkConfigUtils.SERVICE_REGISTRAR"
},
{
"ignore": true,
"code": "java.field.removedWithConstant",
"old": "field io.smallrye.stork.microprofile.MicroProfileConfigProvider.SERVICE_REGISTRAR_EMBEDDED",
"justification": "Moved to stork-core io.smallrye.stork.utils.StorkConfigUtils.SERVICE_REGISTRAR_EMBEDDED"
}
]
"differences" : [ ]
}
}, {
"extension" : "revapi.reporter.json",
Expand Down
19 changes: 1 addition & 18 deletions test-utils/revapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,24 +24,7 @@
"criticality" : "highlight",
"minSeverity" : "POTENTIALLY_BREAKING",
"minCriticality" : "documented",
"differences" : [
{
"ignore": true,
"code": "java.annotation.removed",
"old": "class io.smallrye.stork.test.TestServiceRegistrarProvider",
"new": "class io.smallrye.stork.test.TestServiceRegistrarProvider",
"annotation": "@io.smallrye.stork.api.config.ServiceDiscoveryAttributes({@io.smallrye.stork.api.config.ServiceDiscoveryAttribute(name = \"one\", description = \"no description\"), @io.smallrye.stork.api.config.ServiceDiscoveryAttribute(name = \"two\", description = \"no description\")})",
"justification": "Wrong annotation for Registrar configuration attributes"
},
{
"ignore": true,
"code": "java.annotation.added",
"old": "class io.smallrye.stork.test.TestServiceRegistrarProvider",
"new": "class io.smallrye.stork.test.TestServiceRegistrarProvider",
"annotation": "@io.smallrye.stork.api.config.ServiceRegistrarAttributes({@io.smallrye.stork.api.config.ServiceRegistrarAttribute(name = \"one\", description = \"no description\"), @io.smallrye.stork.api.config.ServiceRegistrarAttribute(name = \"two\", description = \"no description\")})",
"justification": "This is the good annotation for Registrar configuration attributes"
}
]
"differences" : [ ]
}
}, {
"extension" : "revapi.reporter.json",
Expand Down

0 comments on commit fdf8f82

Please sign in to comment.