Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of calls to Json static methods #2165

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Get rid of calls to Json static methods #2165

merged 1 commit into from
Aug 27, 2024

Conversation

jmartisk
Copy link
Member

@jmartisk jmartisk commented Aug 27, 2024 •
edited
Loading

Fixes #2161

@jmartisk
Copy link
Member Author

cc @gsmet

gsmet
gsmet approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end, it's nice because you optimized your library significantly in one hour :).

@gsmet
Copy link
Contributor

gsmet commented Aug 27, 2024

Ideally, if we can get that in a 2.9.2, that would be ideal as I could backport it to 3.14 more easily.

@jmartisk
Copy link
Member Author

Ideally, if we can get that in a 2.9.2, that would be ideal as I could backport it to 3.14 more easily.

Sure, will do

@jmartisk jmartisk merged commit 4c050ce into smallrye:main Aug 27, 2024
5 checks passed
@jmartisk jmartisk deleted the json branch August 27, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of calls to static methods of Json
2 participants
@jmartisk @gsmet