Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1423: add GraphQLResult and wrap successful result #1424

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

t1
Copy link
Collaborator

@t1 t1 commented May 27, 2022

Also: rename Wrapper#isNotEmpty to Wrapper#isNonNull and fix some warnings

TODOs:

  • Map all declared exceptions to fields
    • In the schema
    • When executing
  • Consider @GraphQLResult annotations on an API class
  • Consider @GraphQLResult annotations on a package
  • Provide a config option to globally enable result-wrapping (and add to GraphQLResult javadoc)
  • Maybe consider ErrorCode annotation (but convert kebap to camel?)
  • Documentation

@t1
Copy link
Collaborator Author

t1 commented May 27, 2022

@phillip-kruger: I have several smaller problems that you might be able to help with.

  1. The main branch doesn't compile (GraphQLWSSubprotocolHandler and GraphQLTransportWSSubprotocolHandler)
  2. In the main branch, the ReferenceCreator causes a StackOverflow
  3. I've added a TCK test for result, but it fails because it doesn't find the order method, but the same request runs in the runner!

I could fix 1. and 2., but I don't understand how they got in there.

@t1 t1 requested a review from phillip-kruger May 27, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant