Improve config locations error messages when resource not found

implementation/src/main/java/io/smallrye/config/AbstractLocationConfigSourceLoader.java

@@ -105,15 +105,15 @@ protected List<ConfigSource> loadConfigSources(final String[] locations, final i
     protected List<ConfigSource> tryFileSystem(final URI uri, final int ordinal) {
         final List<ConfigSource> configSources = new ArrayList<>();
         final Path urlPath = uri.getScheme() != null ? Paths.get(uri) : Paths.get(uri.getPath());
-        if (Files.isRegularFile(urlPath)) {
+        if (Files.isRegularFile(urlPath) || "file".equals(uri.getScheme())) {
             consumeAsPath(toURL(urlPath.toUri()), new ConfigSourcePathConsumer(ordinal, configSources));
         } else if (Files.isDirectory(urlPath)) {
             try (DirectoryStream<Path> paths = Files.newDirectoryStream(urlPath, this::validExtension)) {
                 for (Path path : paths) {
                     addConfigSource(path.toUri(), ordinal, configSources);
                 }
             } catch (IOException e) {
-                throw ConfigMessages.msg.failedToLoadResource(e);
+                throw ConfigMessages.msg.failedToLoadResource(e, uri.toString());
             }
         }
         return configSources;
@@ -125,7 +125,7 @@ protected List<ConfigSource> tryClassPath(final URI uri, final int ordinal, fina
         try {
             consumeAsPaths(useClassloader, uri.getPath(), new ConfigSourcePathConsumer(ordinal, configSources));
         } catch (IOException e) {
-            throw ConfigMessages.msg.failedToLoadResource(e);
+            throw ConfigMessages.msg.failedToLoadResource(e, uri.toString());
         } catch (IllegalArgumentException e) {
             configSources.addAll(fallbackToUnknownProtocol(uri, ordinal, useClassloader));
         }
@@ -137,7 +137,7 @@ protected List<ConfigSource> tryJar(final URI uri, final int ordinal) {
         try {
             consumeAsPath(toURL(uri), new ConfigSourcePathConsumer(ordinal, configSources));
         } catch (Exception e) {
-            throw ConfigMessages.msg.failedToLoadResource(e);
+            throw ConfigMessages.msg.failedToLoadResource(e, uri.toString());
         }
         return configSources;
     }
@@ -170,7 +170,7 @@ protected List<ConfigSource> fallbackToUnknownProtocol(final URI uri, final int
                 }
             }
         } catch (IOException e) {
-            throw ConfigMessages.msg.failedToLoadResource(e);
+            throw ConfigMessages.msg.failedToLoadResource(e, uri.toString());
         }
         return configSources;
     }
@@ -224,7 +224,7 @@ private ConfigSource addConfigSource(final URL url, final int ordinal, final Lis
             configSources.add(configSource);
             return configSource;
         } catch (IOException e) {
-            throw ConfigMessages.msg.failedToLoadResource(e);
+            throw ConfigMessages.msg.failedToLoadResource(e, url.toString());
         }
     }
 
@@ -235,7 +235,7 @@ private void addProfileConfigSource(final URL profileToFileName, final int ordin
         } catch (FileNotFoundException | NoSuchFileException e) {
             // It is ok to not find the resource here, because it is an optional profile resource.
         } catch (IOException e) {
-            throw ConfigMessages.msg.failedToLoadResource(e);
+            throw ConfigMessages.msg.failedToLoadResource(e, profileToFileName.toString());
         }
     }
 

implementation/src/main/java/io/smallrye/config/ConfigMessages.java

@@ -121,8 +121,8 @@ public interface ConfigMessages {
     @Message(id = 34, value = "URI Syntax invalid %s")
     IllegalArgumentException uriSyntaxInvalid(@Cause Throwable cause, String uri);
 
-    @Message(id = 35, value = "Failed to load resource")
-    IllegalStateException failedToLoadResource(@Cause Throwable cause);
+    @Message(id = 35, value = "Failed to load resource %s")
+    IllegalStateException failedToLoadResource(@Cause Throwable cause, String location);
 
     @Message(id = 36, value = "Type %s not supported for unwrapping.")
     IllegalArgumentException getTypeNotSupportedForUnwrapping(Class<?> type);

implementation/src/test/java/io/smallrye/config/PropertiesLocationConfigSourceFactoryTest.java

@@ -112,6 +112,13 @@ void notFound() {
 
         assertNull(config.getRawValue("my.prop"));
         assertEquals(0, countSources(config));
+
+        assertThrows(IllegalStateException.class, () -> buildConfig("file:/not/found/not-found.properties"),
+                "Failed to load resource file:/not/found/not-found.properties");
+        assertThrows(IllegalStateException.class, () -> buildConfig("http://not.found/not-found-properties"),
+                "Failed to load resource http://not.found/not-found-properties");
+        assertThrows(IllegalStateException.class, () -> buildConfig("jar:file:/resources-one.jar!/"),
+                "Failed to load resource jar:file:/resources-one.jar!/");
     }
 
     @Test
@@ -175,14 +182,13 @@ void onlyProfileFile(@TempDir Path tempDir) throws Exception {
             devProperties.store(out, null);
         }
 
-        SmallRyeConfig config = new SmallRyeConfigBuilder()
+        SmallRyeConfigBuilder builder = new SmallRyeConfigBuilder()
                 .addDiscoveredSources()
                 .addDefaultInterceptors()
                 .withProfile("common,dev")
-                .withDefaultValue(SMALLRYE_CONFIG_LOCATIONS, tempDir.resolve("config.properties").toUri().toString())
-                .build();
+                .withDefaultValue(SMALLRYE_CONFIG_LOCATIONS, tempDir.resolve("config.properties").toUri().toString());
 
-        assertNull(config.getRawValue("my.prop.profile"));
+        assertThrows(IllegalStateException.class, builder::build);
     }
 
     @Test