Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1305 by fixing pagination with async for syntax #1308

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Nov 28, 2022

Summary

This pull request resolves #1305

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x area:async labels Nov 28, 2022
@seratch seratch self-assigned this Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #1308 (59f67f8) into main (f2f3fd6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1308   +/-   ##
=======================================
  Coverage   85.79%   85.79%           
=======================================
  Files          84       84           
  Lines        7861     7861           
=======================================
  Hits         6744     6744           
  Misses       1117     1117           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit 14c2582 into slackapi:main Nov 28, 2022
@seratch seratch deleted the issue-1305-async-pagination branch November 28, 2022 07:26
@seratch seratch added this to the 3.19.5 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:async bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"admin.conversations.search" API endpoint pagination gives KeyError from AsyncSlackResponse.__anext__()
1 participant