Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaking warnings related to missing accessibility fields text and fallback #1208

Merged
merged 1 commit into from
May 6, 2022

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented May 5, 2022

This follows the pattern in the solution converged on for slackapi/node-slack-sdk#1476.

Wondering if there is an opportunity to DRY the tests up here, especially across the legacy vs. the regular synchronous client code. The tests seem to be a carbon copy. I don't really have a suggestion on how to improve that though, but maybe some more Python-y folks have ideas?

@filmaj filmaj added enhancement M-T: A feature request for new functionality semver:patch web-client area:async labels May 5, 2022
@filmaj filmaj added this to the 3.17.0 milestone May 5, 2022
@filmaj filmaj requested review from seratch and srajiang May 5, 2022 21:28
@filmaj filmaj self-assigned this May 5, 2022
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1208 (d26a0b3) into main (8a4f44b) will increase coverage by 0.00%.
The diff coverage is 95.83%.

@@           Coverage Diff           @@
##             main    #1208   +/-   ##
=======================================
  Coverage   86.55%   86.55%           
=======================================
  Files         111      111           
  Lines       10893    10891    -2     
=======================================
- Hits         9428     9427    -1     
+ Misses       1465     1464    -1     
Impacted Files Coverage Δ
slack_sdk/web/internal_utils.py 94.44% <91.66%> (-0.09%) ⬇️
slack_sdk/web/async_client.py 85.10% <100.00%> (ø)
slack_sdk/web/client.py 86.48% <100.00%> (ø)
slack_sdk/web/legacy_client.py 86.20% <100.00%> (ø)
slack_sdk/socket_mode/builtin/internals.py 72.80% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a4f44b...d26a0b3. Read the comment docs.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -As for the future, having mostly the same tests for WebClient and AsyncWebClient should be fine. As for the legacy client, we won't add tests for future changes. Only in the early days of slack-sdk v3 development, we tended to have tests for both legacy and current clients.

@seratch seratch merged commit 83dc879 into main May 6, 2022
@seratch seratch deleted the fallback-args-warn branch May 6, 2022 01:04
@seratch seratch modified the milestones: 3.17.0, 3.16.1 May 10, 2022
mar3mar3 added a commit to mar3mar3/python-slack-sdk that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:async enhancement M-T: A feature request for new functionality semver:patch web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants