Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing "border" proerty to "rich_text_quote" block element #1753

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Add missing "border" proerty to "rich_text_quote" block element #1753

merged 1 commit into from
Mar 11, 2024

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 5, 2024

Summary

This pull request resolves a bug where the "border" property in "rich_text_quote" block element is missing in #1643 changes.

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented area:typescript issues that specifically impact using the package from typescript projects pkg:types applies to `@slack/types` labels Mar 5, 2024
@seratch seratch added this to the types@3.0.0 milestone Mar 5, 2024
chrisronline
chrisronline approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@filmaj filmaj merged commit 20899b0 into slackapi:main Mar 11, 2024
17 checks passed
@seratch seratch deleted the missing-border branch March 11, 2024 13:13
@filmaj filmaj modified the milestones: types@3.0.0, types@2.12.0 Jun 5, 2024
@filmaj
Copy link
Contributor

filmaj commented Jun 5, 2024

FYI the fix for this has been released to npm as @slack/types v2.12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmaj filmaj filmaj approved these changes

@chrisronline chrisronline chrisronline approved these changes

Assignees
No one assigned
Labels
area:typescript issues that specifically impact using the package from typescript projects bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented pkg:types applies to `@slack/types`
Projects
None yet
Milestone
types@2.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@seratch @filmaj @chrisronline