tsconfig: allow fallthrough in cases in switch, remove related ts-ign…

…ore. the ts-ignore comment is worse than using fallthrough.
slackapi · Sep 14, 2024 · 44e03c9 · 44e03c9
1 parent edd8b9e
commit 44e03c9
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/src/App.ts b/src/App.ts
@@ -1009,7 +1009,6 @@ export default class App<AppCustomContext extends StringIndexed = StringIndexed>
       case IncomingEventType.Shortcut:
         payload = (bodyArg as SlackShortcutMiddlewareArgs['body']);
         break;
-      // @ts-ignore: Fallthrough case in switch
       case IncomingEventType.Action:
         if (isBlockActionOrInteractiveMessageBody(bodyArg as SlackActionMiddlewareArgs['body'])) {
           const { actions } = (bodyArg as SlackActionMiddlewareArgs<BlockAction | InteractiveMessage>['body']);

diff --git a/tsconfig.json b/tsconfig.json
@@ -10,7 +10,6 @@
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noImplicitReturns": true,
-    "noFallthroughCasesInSwitch": true,
     "outDir": "dist",
     "sourceMap": true
   },