Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for plain syntax highlight #4114

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

leovinogradov
Copy link

There is a bug both in V1 and V2 where if you have a syntax code block with some highlighted text in it and select a different language, then select 'plain', some syntax highlights are not removed.

Try it out on quilljs.org by making a code block, putting in some text like
{
"hello": "world"
}
select 'javascript' as the language, then select 'plain'

This PR fixes this behavior by making sure there is no inserts in the diff between old delta and new delta when highlighting as plain

@luin luin self-requested a review April 18, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant