Initial TypeScript setup #3598
Merged
Initial TypeScript setup #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luin
force-pushed
the
zh-ts
branch
2 times, most recently
from
caf578f
to
3530351
Compare
luin
commented
Jun 20, 2022
| @@ -283,25 +314,24 @@ class Selection { | |||
| return range; | |||
| } | |||
|
|
|||
| rangeToNative(range) { | |||
| const indexes = range.collapsed | |||
There was a problem hiding this comment.
Range#collapsed was removed in a refactor: d47f03c.
luin
commented
Jun 21, 2022
| @@ -664,14 +664,5 @@ describe('Selection', function() { | |||
| this.bounds = selection.getBounds(0, 10); | |||
| }).not.toThrow(); | |||
| }); | |||
|
|
|||
| it('empty container', function() { | |||
There was a problem hiding this comment.
I added this test but it actually never passes.
luin
force-pushed
the
zh-ts
branch
4 times, most recently
from
9492390
to
7a3c90b
Compare
luin
force-pushed
the
zh-ts
branch
3 times, most recently
from
0f24095
to
056d07d
Compare
luin
force-pushed
the
zh-ts
branch
2 times, most recently
from
a866729
to
d7f485a
Compare
jhchen
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To minimize changed files, for typing issues, this PR prefers to suppress them with
// @ts-expect-errorunless it's an easy fix.To test:
npm testpasses.npm startand http://localhost:9000/standalone/full/ works.