refactor(typeorm): simplify DB API #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2646 +/- ##
==========================================
- Coverage 84.96% 82.74% -2.23%
==========================================
Files 100 82 -18
Lines 3691 3598 -93
Branches 281 281
==========================================
- Hits 3136 2977 -159
- Misses 551 617 +66
Partials 4 4 ☔ View full report in Codecov by Sentry. |
kyranet
force-pushed
the
refactor/typeorm/simplify-db-api
branch
2 times, most recently
from
0f3590b
to
0450c9c
Compare
kyranet
force-pushed
the
refactor/typeorm/simplify-db-api
branch
from
0450c9c
to
3e3e100
Compare
favna
approved these changes
Jul 23, 2024
RedStar071
added a commit
to wolfstar-project/wolfstar
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes alongside #2644, and makes the migration to Prisma in #2450 much simpler
TODO
rwlock already unlockedinconfSuppressedErrorin transactions