[ENH] Add polars version of dummy proba regressor #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests in |
|
They are not failing because there are no tests covering the new code, i.e., feeding |
fkiraly
added
enhancement
module:regression
This comment was marked as resolved.
This comment was marked as resolved.
|
that's strange. Could you kindly investigate? |
|
oh, I think I got it - the estimator is in a private module. The test framework skips estimators that are private and not publicly exported. |
|
@fkiraly How do we specify to ignore 'pandas dataframe' tests for estimators that do not have pandas specified x/y mtypes? |
|
we should not skip these - it should still work with back/from conversion. |
fkiraly
pushed a commit
that referenced
this pull request
Aug 18, 2024
adds index support as part of #440 and is used to sync up polars conversion utilities between skpro and sktime. Correponding sktime pr for polars conversion utilities is sktime/sktime#6455. In this pr: If a pandas Dataframe is a `from_type` and polars frame is a `to_type` then during the conversion, we will save the index (assumed never to be in multi-index format) and insert it as an individual column with column name `__index__`. Then the resulting pandas dataframe will be converted to a polars dataframe. In the inverse function, if we are converting from polars dataframe to pandas dataframe, if the column `__index__` exists in the pandas dataframe post-conversion, then we will map that column to the index before returning the pandas Dataframe After this is merged, #447 will be implemented as a `polars` only estimator. tests will also be written to check polars input end to end and pandas input and output through the polars estimator (i.e pandas input into polars estimator -> polars predictions -> pandas output)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #440 and is a polars extension of #437
Adds polars version of dummy proba regressor - also to help test e2e input flow of polars tables
In this pull request:
polars_eager_table. However, sinceBaseDistributionobjects are currently is not supported forpolarsDataFrames, we leverage pandas DataFrames inside both_fitand_predict_proba. Otherwise the functionality should mirror [ENH]DummyProbaRegressor- probabilistic dummy regressor #437.skpro.utils.polarsfile which contains 2 functionspolars_split_index_values_frameandpolars_combine_index_values_frame. The goal of these two functions is to split and combine__index__columns in and out of the main polars dataFrame (if they are created via the _convert utils from pandas to polars) in order to properly do predictions or fitting.test_polars.py, as well as other polars tests that is related to the adapter enhancements as part of [ENH] Polars adapter enhancements #449