Init I18n before Notifications start (elastic#23902)

* Init I18n before Notifications start

* Remove i18n initialization in AngularJS since it will be already initialized in CoreSystem

* Remove unused translationsApi

* Remove redundant i18n.init invocation

* Remove i18n tests since  i18n.init was removed and input params for AppBootstrap were changed

* Move i18n initialization to the entry file.

src/ui/public/chrome/chrome.js

@@ -37,7 +37,6 @@ import controlsApi from './api/controls';
 import { initChromeNavApi } from './api/nav';
 import templateApi from './api/template';
 import themeApi from './api/theme';
-import translationsApi from './api/translations';
 import { initChromeXsrfApi } from './api/xsrf';
 import { initUiSettingsApi } from './api/ui_settings';
 import { initLoadingCountApi } from './api/loading_count';
@@ -73,7 +72,6 @@ initAngularApi(chrome, internals);
 controlsApi(chrome, internals);
 templateApi(chrome, internals);
 themeApi(chrome, internals);
-translationsApi(chrome, internals);
 
 const waitForBootstrap = new Promise(resolve => {
   chrome.bootstrap = function (targetDomElement) {

src/ui/public/i18n/index.js

@@ -18,7 +18,6 @@
  */
 
 import { uiModules } from 'ui/modules';
-import { metadata } from 'ui/metadata';
 import {
   I18nProvider,
   i18nFilter,
@@ -28,7 +27,4 @@ import {
 uiModules.get('i18n')
   .provider('i18n', I18nProvider)
   .filter('i18n', i18nFilter)
-  .directive('i18nId', i18nDirective)
-  .config((i18nProvider) => {
-    i18nProvider.init(metadata.translations);
-  });
+  .directive('i18nId', i18nDirective);

src/ui/ui_bundles/app_entry_template.js

@@ -33,10 +33,14 @@ import 'whatwg-fetch';
 import 'abortcontroller-polyfill';
 import 'childnode-remove-polyfill';
 
+import { i18n } from '@kbn/i18n';
 import { CoreSystem } from '__kibanaCore__'
 
+const injectedMetadata = JSON.parse(document.querySelector('kbn-injected-metadata').getAttribute('data'));
+i18n.init(injectedMetadata.legacyMetadata.translations);
+
 new CoreSystem({
-  injectedMetadata: JSON.parse(document.querySelector('kbn-injected-metadata').getAttribute('data')),
+  injectedMetadata,
   rootDomElement: document.body,
   requireLegacyFiles: () => {
     ${bundle.getRequires().join('\n  ')}

src/ui/ui_render/bootstrap/app_bootstrap.js

@@ -24,10 +24,9 @@ import { resolve } from 'path';
 import { i18n } from '@kbn/i18n';
 
 export class AppBootstrap {
-  constructor({ templateData, translations }) {
+  constructor({ templateData }) {
     this.templateData = templateData;
     this._rawTemplate = undefined;
-    i18n.init(translations);
   }
 
   async getJsFile() {

src/ui/ui_render/bootstrap/app_bootstrap.test.js

@@ -57,15 +57,6 @@ describe('ui_render/AppBootstrap', () => {
       expect(contents).toContain('123');
       expect(contents).toContain('/foo/bar');
     });
-
-    test('supports i18n', async () => {
-      expect.assertions(1);
-
-      const bootstrap = new AppBootstrap(mockConfig());
-      const contents = await bootstrap.getJsFile();
-
-      expect(contents).toContain('translated foo');
-    });
   });
 
   describe('getJsFileHash()', () => {
@@ -121,36 +112,11 @@ describe('ui_render/AppBootstrap', () => {
       expect(hash2).toHaveLength(40);
       expect(hash2).not.toEqual(hash1);
     });
-
-    test('resolves to different 40 character string with different translations', async () => {
-      expect.assertions(3);
-
-      const bootstrap1 = new AppBootstrap(mockConfig());
-      const hash1 = await bootstrap1.getJsFileHash();
-
-      const config2 = {
-        ...mockConfig(),
-        translations: {
-          locale: 'en',
-          foo: 'not translated foo'
-        }
-      };
-      const bootstrap2 = new AppBootstrap(config2);
-      const hash2 = await bootstrap2.getJsFileHash();
-
-      expect(typeof hash2).toEqual('string');
-      expect(hash2).toHaveLength(40);
-      expect(hash2).not.toEqual(hash1);
-    });
   });
 });
 
 function mockConfig() {
   return {
-    translations: {
-      locale: 'en',
-      foo: 'translated foo'
-    },
     templateData: {
       appId: 123,
       bundlePath: '/foo/bar'

src/ui/ui_render/ui_render_mixin.js

@@ -75,8 +75,7 @@ export function uiRenderMixin(kbnServer, server, config) {
             appId: app.getId(),
             bundlePath,
             styleSheetPaths,
-          },
-          translations: await server.getUiTranslations()
+          }
         });
 
         const body = await bootstrap.getJsFile();