Skip to content

Commit

Permalink
[Logstash] [Pipeline Viewer] Improve LS monitoring accessibility (ela…
Browse files Browse the repository at this point in the history
…stic#24169)

* Update test data shape to conform to component proptypes.

* Add aria-labels for pipeline viewer buttons.
  • Loading branch information
justinkambic authored Oct 18, 2018
1 parent 9f4ec18 commit 2b6cd21
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ exports[`CollapsibleStatement component renders child components 1`] = `
key="statementId"
>
<EuiButtonIcon
aria-label={true}
aria-label="collapse"
color="text"
iconSize="m"
iconType="arrowDown"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ exports[`PluginStatement component adds warning highlight for cpu time 1`] = `
grow={false}
>
<EuiButtonEmpty
aria-label="mutate"
className="monPipelineViewer__plugin"
color="primary"
flush="left"
Expand Down Expand Up @@ -122,6 +123,7 @@ exports[`PluginStatement component adds warning highlight for event millis 1`] =
grow={false}
>
<EuiButtonEmpty
aria-label="mutate"
className="monPipelineViewer__plugin"
color="primary"
flush="left"
Expand Down Expand Up @@ -215,6 +217,7 @@ exports[`PluginStatement component does not render explicit id field if no id is
grow={false}
>
<EuiButtonEmpty
aria-label="stdin"
className="monPipelineViewer__plugin"
color="primary"
flush="left"
Expand Down Expand Up @@ -283,6 +286,7 @@ exports[`PluginStatement component renders input metrics and explicit id fields
grow={false}
>
<EuiButtonEmpty
aria-label="stdin"
className="monPipelineViewer__plugin"
color="primary"
flush="left"
Expand Down Expand Up @@ -364,6 +368,7 @@ exports[`PluginStatement component renders processor statement metrics 1`] = `
grow={false}
>
<EuiButtonEmpty
aria-label="mutate"
className="monPipelineViewer__plugin"
color="primary"
flush="left"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ exports[`Statement component renders a CollapsibleStatement with else body for n
key="statementName"
>
<EuiButtonEmpty
aria-label="else"
color="text"
flush="left"
iconSide="left"
Expand Down Expand Up @@ -56,6 +57,7 @@ exports[`Statement component renders a CollapsibleStatement with if body for bra
key="statementName"
>
<EuiButtonEmpty
aria-label="if"
color="text"
flush="left"
iconSide="left"
Expand Down Expand Up @@ -145,6 +147,7 @@ exports[`Statement component renders spacers for element with depth > 0 1`] = `
key="statementName"
>
<EuiButtonEmpty
aria-label="else"
color="text"
flush="left"
iconSide="left"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ exports[`StatementList renders nested elements as expected 1`] = `
"depth": 0,
"id": "mutateIf",
"parentId": null,
"statement": Object {},
}
}
expand={[Function]}
Expand All @@ -25,6 +26,7 @@ exports[`StatementList renders nested elements as expected 1`] = `
"depth": 1,
"id": "mutate",
"parentId": "mutateIf",
"statement": Object {},
}
}
expand={[Function]}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,13 @@ describe('StatementList', () => {
id: 'mutateIf',
parentId: null,
depth: 0,
statement: { },
},
{
id: 'mutate',
parentId: 'mutateIf',
depth: 1,
statement: { },
},
],
onShowVertexDetails,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export function CollapsibleStatement(props) {
>
<EuiFlexItem key={id} grow={false}>
<EuiButtonIcon
aria-label
aria-label="collapse"
color="text"
iconType={getToggleIconType(isCollapsed)}
onClick={toggleClicked}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export function PluginStatement({
<EuiFlexGroup alignItems="center" gutterSize="xs" responsive={false}>
<EuiFlexItem grow={false}>
<EuiButtonEmpty
aria-label={name}
className="monPipelineViewer__plugin"
color="primary"
flush="left"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ function renderStatementName(name, onVertexSelected) {
return (
<EuiFlexItem grow={false} key="statementName">
<EuiButtonEmpty
aria-label={name}
color="text"
size="xs"
onClick={onVertexSelected}
Expand Down

0 comments on commit 2b6cd21

Please sign in to comment.