Add support for React Native window location format Fixes sinonjs/sin…

[greena13]

Purpose (TL;DR)

Fix issue #1362 and allows sinon to be used with React Native builds (where the location object is not stored directly on window).

Preserves existing behaviour for all other environments, including fallback object.

How to verify

1. Check out this branch (see github instructions below)

2. npm install

3. import sinon into a React Native project and test on Android and iOS that it does not raise the error

   undefined is not an object (evaluating 'wloc.protocol')

[coveralls]

Coverage decreased (-0.04%) to 95.334% when pulling 8f0e570 on greena13:master into f701abe on sinonjs:master.

[coveralls]

Coverage decreased (-0.04%) to 95.334% when pulling deee3dd on greena13:master into f701abe on sinonjs:master.

[coveralls]

Coverage decreased (-0.04%) to 95.334% when pulling 43b1768 on greena13:master into f701abe on sinonjs:master.

[coveralls]

Coverage decreased (-0.04%) to 95.334% when pulling 77a360a on greena13:master into f701abe on sinonjs:master.

[fatso83]

wow, that is proper weird, but if this works ... then fine.

window.window.location? jeez 😸

[greena13]

Yes, for reasons unknown to me, this does indeed seem to be where location is stored, in the versions of React Native that I tested against.

[mroderick]

When you use return inside if statements, you can avoid using else.

See http://rmurphey.com/blog/2012/12/10/js-conditionals

Also, you can unfold this code a bit, so there are fewer levels of indentation == easier to understand.

function getWindowLocation() {
    if (typeof window === "undefined") {
        // Fallback
        return getDefaultWindowLocation();
    }

    if (typeof window.location !== "undefined") {
        // Browsers place location on window
        return window.location;
    }

    if ((typeof window.window !== "undefined") && (typeof window.window.location !== "undefined")) {
        // React Native on Android places location on window.window
        return window.window.location;
    }

    return getDefaultWindowLocation();

}

[greena13]

Thanks for your suggestion. I agree, it can be simplified in this way.

[coveralls]

Coverage decreased (-0.02%) to 95.351% when pulling 4fe0a73 on greena13:master into f701abe on sinonjs:master.

[greena13]

Patch suggestions applied. :)

[fatso83]

Thanks for your contributions!

[mroderick]

sinon@2.2.0 is now on npm