Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade docusaurus to version 3 #625

Merged
merged 10 commits into from
Mar 6, 2024
Merged

Conversation

MilanKovacic
Copy link
Contributor

@MilanKovacic MilanKovacic commented Mar 4, 2024

Close #624 first!

@MilanKovacic MilanKovacic marked this pull request as ready for review March 4, 2024 16:00
Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review each file since a lot of it was prettier changes. Did you follow the steps in the Docusaurus v3 migration guide? Are there any differences in how the website functions

@MilanKovacic
Copy link
Contributor Author

I didn't review each file since a lot of it was prettier changes. Did you follow the steps in the Docusaurus v3 migration guide? Are there any differences in how the website functions

History should be clean now.
Yes, I've followed all of the steps.

  1. Node upgraded to 20
  2. All packages upgraded to latest versions
  3. Fixed breaking change related to versioned docs (prefix is not needed anymore)

Website should function and look the same.

@@ -1,12 +1,12 @@
{
"version-4.x/docs": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that changed with docusaurus@3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, ths is not needed or supported anymore: facebook/docusaurus#9310.

@MilanKovacic MilanKovacic merged commit 2cc03bc into master Mar 6, 2024
1 check passed
@MilanKovacic MilanKovacic deleted the chore/upgrade-docusaurus branch March 6, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants