Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for null ids when we see events for invoices #40

Merged
merged 6 commits into from
Jul 30, 2019
Merged

Check for null ids when we see events for invoices #40

merged 6 commits into from
Jul 30, 2019

Conversation

luandy64
Copy link
Contributor

I could go either way with the string formatting. Pylint is happy with breaking it up

dmosorast
dmosorast requested changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes that came to mind off the top of my head.

tap_stripe/__init__.py Outdated Show resolved Hide resolved
tap_stripe/__init__.py Outdated Show resolved Hide resolved
@luandy64 luandy64 merged commit 4adb53e into master Jul 30, 2019
@luandy64 luandy64 deleted the fix/null-ids branch July 30, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmosorast dmosorast dmosorast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luandy64 @dmosorast