Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types: Allow promises in afterResponse hook #883

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Fix types: Allow promises in afterResponse hook #883

merged 2 commits into from
Sep 20, 2019

Conversation

jaulz
Copy link
Contributor

@jaulz jaulz commented Sep 19, 2019 •
edited by sindresorhus
Loading

Solves #876

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates.

@jaulz jaulz mentioned this pull request Sep 19, 2019
Closed
@jaulz @szmarczak
fix: lint
1c86e81 
Co-Authored-By: Szymon Marczak <36894700+szmarczak@users.noreply.github.com>
@jaulz
Copy link
Contributor Author

jaulz commented Sep 20, 2019

@szmarczak updated the PR 😊

@sindresorhus sindresorhus changed the title fix(types): allow promises in afterResponseHook Fix types: Allow promises in afterResponse hook Sep 20, 2019
@sindresorhus sindresorhus merged commit d0c2f05 into sindresorhus:master Sep 20, 2019
@jaulz jaulz deleted the patch-2 branch October 1, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szmarczak szmarczak szmarczak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaulz @szmarczak @sindresorhus