Fix Electron throwing HTTP trailers are not supported error
#598
Conversation
| return is.function(value) ? value.bind(target) : value; | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
Why not just this?
if (options.useElectronNet) {
response.trailers = [];
response.rawTrailers = [];
}There was a problem hiding this comment.
Because electron set throwing getters for these. We need to override the getters.
There was a problem hiding this comment.
I see. You could use Object.defineProperty, but I guess this is safer.
source/request-as-event-emitter.js
Outdated
| @@ -47,13 +47,26 @@ module.exports = options => { | |||
|
|
|||
| /* istanbul ignore next: electron.net is broken */ | |||
| if (options.useElectronNet && process.versions.electron) { | |||
| const electron = global['require']('electron'); // eslint-disable-line dot-notation | |||
| const electron = require('electron'); | |||
There was a problem hiding this comment.
It was like this for a reason. It's to prevent Webpack from complaining. I guess we should add a comment about that.
There was a problem hiding this comment.
IDK why but the "global" approach was throwing an error for me. I'll try that again.
There was a problem hiding this comment.
This is what I get:
(node:8174) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: global.require is not a functionThere was a problem hiding this comment.
Hmm, how about this then:
const r = ({x: require})['yx'.slice(1)];
const electron = r('electron');I would be impressed if Webpack managed to decipher that 😝
source/request-as-event-emitter.js
Outdated
| fn = electron.net || electron.remote.net; | ||
| } | ||
|
|
||
| let timings; | ||
| const cacheableRequest = new CacheableRequest(fn.request, options.cache); | ||
| const cacheReq = cacheableRequest(options, response => { | ||
| if (options.useElectronNet) { |
There was a problem hiding this comment.
Can you add a comment with a link to the Electron issue this fixes?
source/request-as-event-emitter.js
Outdated
| @@ -1,4 +1,6 @@ | |||
| 'use strict'; | |||
| /* istanbul ignore next: webpack only */ | |||
| const r = ({x: require})['yx'.slice(1)]; | |||
There was a problem hiding this comment.
This is only used in one place, so just put it inline with the function call at line 50.
sindresorhus
changed the title
HTTP trailers are not supported errorHTTP trailers are not supported error
|
Can you fix the merge conflict? |
Fixes #461