Improve no-array-for-each rule docs
#1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papb
reviewed
Mar 24, 2021
docs/rules/no-array-for-each.md
Outdated
|
|
||
| This rule is partly fixable. | ||
|
|
||
| Note that this rule may erroneously catch/fix loops with arrays that are not iterable and thus cannot be converted to for-of loops. |
There was a problem hiding this comment.
I had experienced issues where this rule (and also the unicorn/prefer-spread rule) erroneously converted someObj.forEach(...) to a for-of loop in my Ember app leading to the x is not iterable error, but it turns out someObj was just an object that implemented array functions like forEach (see Ember.ArrayProxy#forEach) and was not actually iterable.
I removed this warning for now.
bmish
changed the title
no-array-for-each rule docno-array-for-each rule doc
sindresorhus
changed the title
no-array-for-each rule docno-array-for-each rule docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.