Improve the default look of showAboutWindow()
on Linux and Windows
#50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since defaults don't exist for Linux in the base Electron package (electron/electron#18918), I figure that
showAboutWindow()
could set some of these defaults and then use the standard About dialog. Until the defaults are standardized by the Electron (electron/electron#23851), this would be a way to get consistency across Windows and Linux.The documentation would need to be updated to reflect these changes, which I can add after the changes are finalized.
Example using Caprine:
About window on
main
branch:With this PR:
Adding
copyright
andwebsite
to Caprine's about menu:[Note: This does not fix the icon getting messed up when packaged into a .deb file.]
Perhaps the defaults set here should be marked with a
TODO
comment while waiting for Electron to set defaults?