Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the default look of showAboutWindow() on Linux and Windows #50

Merged
merged 6 commits into from
Jun 30, 2021

Conversation

mquevill
Copy link
Contributor

Since defaults don't exist for Linux in the base Electron package (electron/electron#18918), I figure that showAboutWindow() could set some of these defaults and then use the standard About dialog. Until the defaults are standardized by the Electron (electron/electron#23851), this would be a way to get consistency across Windows and Linux.

The documentation would need to be updated to reflect these changes, which I can add after the changes are finalized.

Example using Caprine:
About window on main branch:
about_old
With this PR:
about_new
Adding copyright and website to Caprine's about menu:
about_added

[Note: This does not fix the icon getting messed up when packaged into a .deb file.]

Perhaps the defaults set here should be marked with a TODO comment while waiting for Electron to set defaults?

@sindresorhus
Copy link
Owner

Perhaps the defaults set here should be marked with a TODO comment while waiting for Electron to set defaults?

👍 Always good to add TODOs for future possible improvements (and include links to relevant issues)

@sindresorhus
Copy link
Owner

I'm ok with this. Feel free to update the docs (and index.d.ts)

@sindresorhus sindresorhus changed the title Simplify showAboutWindow() logic and set defaults Improve the default look of showAboutWindow() on Linux Jun 30, 2021
@sindresorhus sindresorhus changed the title Improve the default look of showAboutWindow() on Linux Improve the default look of showAboutWindow() on Linux and Windows Jun 30, 2021
@sindresorhus sindresorhus merged commit d8d21a1 into sindresorhus:main Jun 30, 2021
@mquevill mquevill deleted the ImproveAbout branch July 6, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants