Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve index.html when in app.asar #26

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Conversation

ibash
Copy link
Contributor

@ibash ibash commented Nov 5, 2020

Steps:

  1. Set directory to be "." (e.g. serve from app.asar directly)
  2. Bundle an electron app

Expected:
app://- serves index.html

Actual:
extname(".../app.asar") returns .asar, which fails the guard and serves
file not found.

index.js Outdated Show resolved Hide resolved
Steps:
1. Set directory to be "." (e.g. serve from app.asar directly)
2. Bundle an electron app

Expected:
app://- serves index.html

Actual:
extname(".../app.asar") returns .asar, which fails the guard and serves
file not found.
@sindresorhus sindresorhus changed the title Serve index.html when in app.asar Serve index.html when in app.asar Nov 20, 2020
@sindresorhus sindresorhus merged commit 1f196d3 into sindresorhus:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants