Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update type for input and optiopns and update README #122

Merged
merged 7 commits into from
Jan 13, 2024

Conversation

yutak23
Copy link
Contributor

@yutak23 yutak23 commented Jan 12, 2024

This resolves the issue #121.

I am updating the README to match the TypeScript type definitions.

Note Regarding the existing type definitions, I don't see any problem with the existing type definitions. This is because the map-obj functionality that camelcase-keys relies on appears to be intended to convert key-value record types, not object types.

readme.md Outdated Show resolved Hide resolved
expectType<string[]>(camelcaseKeys(['name 1', 'name 2']));

expectType<string[]>(camelcaseKeys(['name 1', 'name 2'], {deep: true}));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the unsupported array format test.

@yutak23 yutak23 changed the title docs: update type for input and optiopns fix: update type for input and optiopns and update README Jan 12, 2024
@sindresorhus sindresorhus merged commit c6ef8fe into sindresorhus:main Jan 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants