Allow apostrophe and interpunct in first word of item description #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Dec 7, 2022
rules/list-item.js
Outdated
| @@ -250,7 +250,7 @@ function validateListItemPrefixCasing(prefix, file) { | |||
| return false; | |||
| } | |||
|
|
|||
| if (!listItemPrefixCaseAllowList.has(caseOf(firstWord)) && !/\d/.test(firstWord) && !/^["“'(]/.test(firstWord) && !identifierAllowList.has(firstWord)) { | |||
| if (!listItemPrefixCaseAllowList.has(caseOf(firstWord.replace(/['·]/,''))) && !/\d/.test(firstWord) && !/^["“'(]/.test(firstWord) && !identifierAllowList.has(firstWord)) { | |||
There was a problem hiding this comment.
I think it would be more correct to strip anything non-ASCII. For example, there are many more kinds of apostrophe's.
Strip all non-word characters from first word before checking case.
|
@sindresorhus Ok, I changed the rule so it strips any non-word character: [^\w], equivalent to [a-zA-Z_0-9]. The change is in 2ece4a9 |
|
Linting is failing. Always run |
|
Ok, I ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153.
This PR fixes the errors that appear when having apostrophes or interpuncts in the first word of the description. Examples that produced an error but now pass: