This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
Kafka auth #510
Open
Kafka auth #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data-collector
data-forwarder
kiln_lib
report-parser
slack-connector
labels
DM-sb
commented
Sep 22, 2021
| @@ -8,7 +8,7 @@ kiln_lib = { git = "https://github.com/simplybusiness/Kiln", features = [ "json" | |||
| clap = "2" | |||
| chrono = "0.4" | |||
| reqwest = { version = "0.11", features = [ "blocking", "json",] } | |||
| git2 = "0.13" | |||
| git2 = "0.12" | |||
There was a problem hiding this comment.
At present the CI/CD build for data forwarder fails without this change. Potentially related to this rust-lang/rust#85574
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Adds support for authentication. At present we only have support for SASL PLAIN mechanism.
Why is it important?
Allows the different kiln components to authenticate to the broker.
Checklist
If this PR introduces a new tool: