This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
WIP (SIMP-) Update to use puppetlabs/docker 2.0.0 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-vaughan
force-pushed
the
docker-2
branch
from
590eebe
to
0f029e9
Compare
jeefberkey
changed the title
jeefberkey
changed the title
|
Making a PR upstream to support OEL |
op-ct
reviewed
Oct 30, 2018
| @@ -5,6 +5,8 @@ | |||
| # https://puppet.com/docs/pe/2017.3/overview/getting_support_for_pe.html#standard-releases-and-long-term-support-releases | |||
There was a problem hiding this comment.
Suggested change
| # https://puppet.com/docs/pe/2017.3/overview/getting_support_for_pe.html#standard-releases-and-long-term-support-releases | |
| # https://puppet.com/docs/pe/2018.1/getting_support_for_pe.html#standard-releases-and-long-term-support-releases |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug regarding the group
docker::runuses, where it uses the default from the module and not the group set in the main class. I have made an upstream ticket puppetlabs/puppetlabs-docker#321. The acceptance test creates thedockergroup in the meantime so the tests pass.