Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITMS-90345: Metadata/Info.plist Mismatch #5

Closed
Badisi opened this issue Aug 27, 2020 · 3 comments
Closed

ITMS-90345: Metadata/Info.plist Mismatch #5

Badisi opened this issue Aug 27, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@Badisi
Copy link

Badisi commented Aug 27, 2020

Issue

I got the following issue from Apple after trying ios-uploader@1.1.0:

ITMS-90345: Metadata/Info.plist Mismatch - The value for bundle_short_version_string in the metadata.xml file does not match the value for CFBundleShortVersionString in app - DEV [Payload/app - DEV.app].

Fix

index.js - line 37

 .replace('BUNDLE_SHORT_VERSION', ctx.bundleVersion) // <-- this should be ctx.bundleShortVersion
 .replace('BUNDLE_VERSION', ctx.bundleVersion)

I would also change the following log in order to have something like X.X.X (XX) (ie. version (build)):

cli.js - line 38

console.log(`Found Bundle ID "${ctx.bundleId}", Bundle Version ${ctx.bundleShortVersion} (${ctx.bundleVersion}).`);
@Badisi
Copy link
Author

Badisi commented Aug 27, 2020

Except this last issue, everything is working fine !
So a big thank you 👏

@simonnilsson
Copy link
Owner

You are absolutely right, an autocomplete typo on my part probably.

Good suggestion on modifying the message.

@simonnilsson simonnilsson added the bug Something isn't working label Aug 27, 2020
simonnilsson added a commit that referenced this issue Aug 27, 2020
@simonnilsson
Copy link
Owner

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants