Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This pull request addresses issue #2221 #2239

Merged
merged 7 commits into from
Aug 19, 2024
Merged

This pull request addresses issue #2221 #2239

merged 7 commits into from
Aug 19, 2024

Conversation

mjdiff
Copy link
Contributor

@mjdiff mjdiff commented Jul 21, 2024

Added option to save 4D data after reduction where the dimension is: N_frames x Channel x X_dim x Y_dim:

one file with 4D data,i.e., like NumPy format
append frames to stack, i.e., like edf
create separate files for each channel, i.e., like tif (Pilatus)

@mjdiff mjdiff added the proposal Something which have to be tested label Jul 21, 2024
@mjdiff mjdiff requested review from kif and EdgarGF93 July 21, 2024 18:55
Copy link
Member

@kif kif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Ideally one should provide a non regression test.

@kif
Copy link
Member

kif commented Aug 19, 2024

close #2221

@kif kif merged commit 8ab8769 into silx-kit:main Aug 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Something which have to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants