-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix serialization of LazyObject #320
Conversation
37cb9b1
to
c0669c1
Compare
Seems like something we need, but I'd like to understand the use case. How do you end up with a lazy object? Maybe our test can better reflect that, instead of direct instantiation. I don't think it needs to be a union test though, just handling of values in general. Happy to re-arrange after you let me know though. Also remember you can run |
c0669c1
to
efb7fc9
Compare
I encountered this exception due to https://github.com/mozilla/django-csp/blob/main/csp/middleware.py#L32 For the test, I was just replicating the exact exception I was trying to fix. But you're right, it doesn't have to be a union test. |
efb7fc9
to
c14c296
Compare
@crgwbr sorry to intervene, do you think this could be used to pass |
Yeah, absolutely. |
@crgwbr this is ready to go, but I need you to make an empty commit |
@silviogutierrez Done, but did it as a rebase instead to avoid the extra junk commits. |
@crgwbr : thanks, note that's not necessary because all commits on this project are squash & merge, so you'll only see a single commit in the main log. [Cue religious war] |
Invariant in union serialization
when the value is a LazyObject
No description provided.