Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create AIX mainline support #13

Merged
merged 4 commits into from
Mar 6, 2019
Merged

Conversation

ThePrez
Copy link
Contributor

@ThePrez ThePrez commented Mar 6, 2019

Addresses issue #5.

I tested and verified that the sunos implementation works for mainline AIX, since the netstat output is the same format. So, I just have it use the sunos module on AIX.

I tried several ways to do this if logic, including burying all the logic in the aix.js module, creating a new module and dynamically exporting the proper entry point from aix.js, and a couple others. In my opinion, this was the cleanest way, but we can refactor the best way you see fit.

Thanks!

@silverwind
Copy link
Owner

Approach seems fine, I probably will refactor this netstat parsing across platforms later to reduce code duplication. The branch seems to be in conflict, can you rebase?

@silverwind
Copy link
Owner

Also need to update package.json to include the renamed file.

@ThePrez
Copy link
Contributor Author

ThePrez commented Mar 6, 2019

Oops! Sorry for missing package.json

@silverwind
Copy link
Owner

I take it make test passes on AIX? If you do not have IPv6, run CI=true make test to skip it.

@ThePrez
Copy link
Contributor Author

ThePrez commented Mar 6, 2019

Yep, make test is clean
(sorry for the earlier linting errors, for some reason I was going straight to node --pending-deprecation --trace-deprecation --throw-deprecation --trace-warnings test.js)

@silverwind silverwind merged commit eb1bce7 into silverwind:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants