Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget buttons for transclusions (#942) #1013

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

onespaceman
Copy link
Contributor

No description provided.

@zefhemel
Copy link
Collaborator

zefhemel commented Aug 3, 2024

Stream of consciousness ahead:

What I had in mind the Edit button would do is navigate to the transcluded page. However, now that I'm thinking about it this is somewhat inconsistent with the general Edit button meaning on widgets, which usually indeed puts the cursor inside the body to allow you to edit the source (query, template).

Now the question is: what is the "source" in this case, the link itself, or the page it links to?

In practice what I would want to do when pushing this edit button is edit the underlying page (that is transcluded) so I'd still prefer the navigate option. Do you agree?

@onespaceman
Copy link
Contributor Author

Sounds reasonable. I could also change the icon to a link and hover text to "Open page" so there's no ambiguity.

@zefhemel
Copy link
Collaborator

zefhemel commented Aug 3, 2024

Sounds good

@zefhemel
Copy link
Collaborator

zefhemel commented Aug 8, 2024

Ready to look at again?

@onespaceman
Copy link
Contributor Author

yes

@zefhemel zefhemel merged commit 7c23e8d into silverbulletmd:main Aug 8, 2024
1 check passed
@zefhemel
Copy link
Collaborator

zefhemel commented Aug 8, 2024

Works great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants