Use take_mut instead of a bespoke unsafe block with mem::replace #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 14 14
Lines 1301 1301
=======================================
Hits 1190 1190
Misses 111 111
Continue to review full report at Codecov.
|
|
FWIW this borrow-checks but I have not tested this |
sile
approved these changes
Jun 30, 2019
There was a problem hiding this comment.
LGTM.
mem::uninitializedis getting deprecated because it's impossible to use it safely in generic code.
I see. Thank you for letting me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mem::uninitializedis getting deprecated because it's impossible to use it safely in generic code.On the other hand,
take_muthas been reviewed by the Unsafe Code Guidelines WG and has been found to be sound.