Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OIDC claim mapping table to reflect the current state #1801

Merged

Conversation

richardfan1126
Copy link
Contributor

@richardfan1126 richardfan1126 commented Sep 10, 2024

Summary

As discussed in #1074 (comment), I am going to update the OIDC claim mapping table to reflect the current working mapping in production.

The changes in this PR are follows:

Release Note

N/A

Documentation

N/A

@richardfan1126 richardfan1126 marked this pull request as ready for review September 10, 2024 07:03
@richardfan1126 richardfan1126 changed the title Update doc oid claim mapping Update OIDC claim mapping table to reflect the current state Sep 10, 2024
Signed-off-by: Richard Fan <richardfan1126@gmail.com>
Signed-off-by: Richard Fan <richardfan1126@gmail.com>
Signed-off-by: Richard Fan <richardfan1126@gmail.com>
Signed-off-by: Richard Fan <richardfan1126@gmail.com>
Signed-off-by: Richard Fan <richardfan1126@gmail.com>
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@haydentherapper haydentherapper enabled auto-merge (squash) September 11, 2024 16:13
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.31%. Comparing base (cf238ac) to head (ef8dd1c).
Report is 198 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1801      +/-   ##
==========================================
- Coverage   57.93%   50.31%   -7.63%     
==========================================
  Files          50       70      +20     
  Lines        3119     4180    +1061     
==========================================
+ Hits         1807     2103     +296     
- Misses       1154     1844     +690     
- Partials      158      233      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haydentherapper haydentherapper merged commit f019ef6 into sigstore:main Sep 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants