Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It creates a action for a nightly release #1792

Closed
wants to merge 1 commit into from

Conversation

javanlacerda
Copy link
Contributor

Summary

It implements a action for having a nightly release for Fulcio.
This is part of a project for having a continuous deployment of Fulcio for Public good instance staging.

Release Note

Documentation

Signed-off-by: Javan lacerda <javanlacerda@google.com>
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.31%. Comparing base (cf238ac) to head (c0b06d9).
Report is 195 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1792      +/-   ##
==========================================
- Coverage   57.93%   50.31%   -7.63%     
==========================================
  Files          50       70      +20     
  Lines        3119     4180    +1061     
==========================================
+ Hits         1807     2103     +296     
- Misses       1154     1844     +690     
- Partials      158      233      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javanlacerda javanlacerda changed the title it creates a action for a nightly release It creates a action for a nightly release Sep 3, 2024
@haydentherapper
Copy link
Contributor

I didn't realize that we have CI to push a container to GCR whenever a commit is pushed to HEAD - https://github.com/sigstore/fulcio/blob/50abb65f0bdcb2c0290b3afb535bc77e339e1a19/.github/workflows/container-build.yml

Would this work instead? Do we need an easier way to discover these, would it help if we tagged these releases as well?

cc @cpanato

@cpanato
Copy link
Member

cpanato commented Sep 4, 2024

I would prefer we use the existing one, we will get rid from the cloudbuild soon as well

the existing images that we publish in github works for you?

@haydentherapper
Copy link
Contributor

Are we publishing at-HEAD containers to GHCR? From the GHA, it seems like we're only publishing to GCR (which for what it's worth, I think we should maintain given there's an SLO for GCR and not for GHCR)

@cpanato
Copy link
Member

cpanato commented Sep 4, 2024

Are we publishing at-HEAD containers to GHCR? From the GHA, it seems like we're only publishing to GCR (which for what it's worth, I think we should maintain, given there's an SLO for GCR and not for GHCR)

ahh yeah that is correct.

we also can start publishing to ghcr is need

@haydentherapper
Copy link
Contributor

If we're already publishing to GCR, that seems sufficient to me!

@javanlacerda
Copy link
Contributor Author

It seems perfect. As I noticed, the tag used is the last commit hash right?

@javanlacerda
Copy link
Contributor Author

I'm closing this PR as we decided to use the images created by the container-build workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants