add github&gitlab reference support to generate-key-pair #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentrax
reviewed
Oct 5, 2021
There was a problem hiding this comment.
Good job! I just added some reviews. Additionally, you can update the usage examples for generate-key-pair command like following:
# generate a key-pair in GitHub
cosign generate-key-pair github://owner/project
# generate a key-pair in GitLab
cosign generate-key-pair gitlab://owner/project
developer-guy
changed the title
developer-guy
force-pushed
the
feature/git-key-pair
branch
3 times, most recently
from
f8f388b
to
9f4f3b9
Compare
dekkagaijin
approved these changes
Oct 5, 2021
Signed-off-by: Erkan Zileli <erkan.zileli@trendyol.com> Co-authored-with: Batuhan Apaydın <batuhan.apaydin@trendyol.com> Co-authored-with: Furkan Türkal <furkan.turkal@trendyol.com>
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
developer-guy
force-pushed
the
feature/git-key-pair
branch
from
9f4f3b9
to
3434196
Compare
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
thanks for the feedback, we updated docs and also generated documents for the commands by following command: $ go run ./cmd/help/main.go # this will update doc/ folder with the latest updates on the commands |
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
dekkagaijin
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Erkan Zileli erkan.zileli@trendyol.com
Co-authored-with: Batuhan Apaydın batuhan.apaydin@trendyol.com
Co-authored-with: Furkan Türkal furkan.turkal@trendyol.com
Fixes: #838
cc: @Dentrax @developer-guy