Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the dupe detector, this isn't needed anymore with the new interf… #456

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Drop the dupe detector, this isn't needed anymore with the new interf… #456

merged 1 commit into from
Jul 19, 2021

Conversation

dlorenc
Copy link
Member

@dlorenc dlorenc commented Jul 19, 2021

…aces

@loosebazooka
Copy link
Member

missed opportunity @dlorenc
image

dekkagaijin
dekkagaijin approved these changes Jul 19, 2021
View reviewed changes
cmd/cosign/cli/sign.go Outdated Show resolved Hide resolved
Drop the dupe detector, this isn't needed anymore with the new interf…
2ce7aeb 
…aces

Signed-off-by: Dan Lorenc <dlorenc@google.com>
@dlorenc dlorenc merged commit d08c803 into sigstore:main Jul 19, 2021
@dlorenc dlorenc deleted the dropdup branch July 19, 2021 20:15
@cpanato cpanato added this to the v1.0.0 milestone Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekkagaijin dekkagaijin dekkagaijin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dlorenc @loosebazooka @dekkagaijin @cpanato