fix(clean): Fix clean cmd for private registries #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3446 +/- ##
==========================================
- Coverage 30.23% 29.88% -0.35%
==========================================
Files 155 155
Lines 9958 10004 +46
==========================================
- Hits 3011 2990 -21
- Misses 6497 6581 +84
+ Partials 450 433 -17 ☔ View full report in Codecov by Sentry. |
Without this patch, running `cosign clean` on an image in a private registry uses the wrong object reference and fails to delete artifacts for the image. On Dockerhub, it is sufficient to call DELETE directly on an object name: ``` DELETE /v2/namespace/repo/manifests/sha256-deadbeef.sig ``` On registry version v2.3 and greater, this does not work. Instead, we need to perform a GET to retrieve the object digest, and call DELETE on that: ``` GET /v2/namespace/repo/manifests/sha256-deadbeef.sig => ... Docker-Content-Digest: sha256:cafeb0ba DELETE /v2/namespace/repo/manifests/sha256:cafeb0ba ``` Since we can't know what type of registry we're dealing with, we try the original version first, and the new version as a fallback. See the GitHub issue[1] which explains the issue, and the API documentation[2]. This also fixes a minor formatting issue in the error message. [1] distribution/distribution#1579 [2] https://github.com/distribution/distribution/blob/main/docs/content/spec/api.md#deleting-an-image Fixes sigstore#2265 Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
haydentherapper
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, running
cosign cleanon an image in a private registry uses the wrong object reference and fails to delete artifacts for the image.On Dockerhub, it is sufficient to call DELETE directly on an object name:
On registry version v2.3 and greater, this does not work. Instead, we need to perform a GET to retrieve the object digest, and call DELETE on that:
Since we can't know what type of registry we're dealing with, we try the original version first, and the new version as a fallback.
See the GitHub issue[1] which explains the issue, and the API documentation[2].
This also fixes a minor formatting issue in the error message.
[1] distribution/distribution#1579
[2] https://github.com/distribution/distribution/blob/main/docs/content/spec/api.md#deleting-an-image
Fixes #2265
Summary
See above
Release Note
Fixed the "clean" command for private registries.
Documentation
n/a