Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix option description: "sign" --> "verify" #2306

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

ChristianCiach
Copy link
Contributor

This is probably a copy/paste-mistake, since the text is the same as in https://github.com/sigstore/cosign/blob/main/cmd/cosign/cli/options/sign.go

The help text was originally added by #615

Release Note

NONE

cpanato
cpanato previously approved these changes Oct 4, 2022
@cpanato
Copy link
Member

cpanato commented Oct 4, 2022

thank you!

@znewman01
Copy link
Contributor

You'll need to run make docgen and commit the resulting changes to update the docs.

@ChristianCiach
Copy link
Contributor Author

Sorry, I am not a Go developer. I tried to do exactly that, but it errors out for reasons I cannot understand and don't seem related to this PR at all:

go run -tags pivkey,pkcs11key,cgo ./cmd/help/
# golang.org/x/exp/constraints
/home/christianc/go/pkg/mod/golang.org/x/exp@v0.0.0-20220823124025-807a23277127/constraints/constraints.go:13:2: invalid character U+007E '~'
/home/christianc/go/pkg/mod/golang.org/x/exp@v0.0.0-20220823124025-807a23277127/constraints/constraints.go:13:7: syntax error: unexpected |, expecting semicolon or newline or }
/home/christianc/go/pkg/mod/golang.org/x/exp@v0.0.0-20220823124025-807a23277127/constraints/constraints.go:20:2: invalid character U+007E '~'
/home/christianc/go/pkg/mod/golang.org/x/exp@v0.0.0-20220823124025-807a23277127/constraints/constraints.go:20:8: syntax error: unexpected |, expecting semicolon or newline or }
/home/christianc/go/pkg/mod/golang.org/x/exp@v0.0.0-20220823124025-807a23277127/constraints/constraints.go:27:9: syntax error: unexpected |, expecting semicolon or newline or }
/home/christianc/go/pkg/mod/golang.org/x/exp@v0.0.0-20220823124025-807a23277127/constraints/constraints.go:34:2: invalid character U+007E '~'
/home/christianc/go/pkg/mod/golang.org/x/exp@v0.0.0-20220823124025-807a23277127/constraints/constraints.go:34:11: syntax error: unexpected |, expecting semicolon or newline or }
/home/christianc/go/pkg/mod/golang.org/x/exp@v0.0.0-20220823124025-807a23277127/constraints/constraints.go:41:2: invalid character U+007E '~'
/home/christianc/go/pkg/mod/golang.org/x/exp@v0.0.0-20220823124025-807a23277127/constraints/constraints.go:41:13: syntax error: unexpected |, expecting semicolon or newline or }
/home/christianc/go/pkg/mod/golang.org/x/exp@v0.0.0-20220823124025-807a23277127/constraints/constraints.go:49:10: syntax error: unexpected |, expecting semicolon or newline or }
/home/christianc/go/pkg/mod/golang.org/x/exp@v0.0.0-20220823124025-807a23277127/constraints/constraints.go:49:10: too many errors
note: module requires Go 1.18
# github.com/theupdateframework/go-tuf/internal/roles
/home/christianc/go/pkg/mod/github.com/theupdateframework/go-tuf@v0.5.1-0.20220920170306-f237d7ca5b42/internal/roles/roles.go:27:20: undefined: strings.Cut
note: module requires Go 1.18
# go.uber.org/atomic
/home/christianc/go/pkg/mod/go.uber.org/atomic@v1.10.0/error.go:55:12: x.v.CompareAndSwap undefined (type Value has no field or method CompareAndSwap)
/home/christianc/go/pkg/mod/go.uber.org/atomic@v1.10.0/error.go:61:24: x.v.Swap undefined (type Value has no field or method Swap)
/home/christianc/go/pkg/mod/go.uber.org/atomic@v1.10.0/string.go:58:12: x.v.CompareAndSwap undefined (type Value has no field or method CompareAndSwap)
/home/christianc/go/pkg/mod/go.uber.org/atomic@v1.10.0/string.go:64:12: x.v.Swap undefined (type Value has no field or method Swap)
note: module requires Go 1.18
# golang.org/x/sys/unix
/home/christianc/go/pkg/mod/golang.org/x/sys@v0.0.0-20220919091848-fb04ddd9f9c8/unix/syscall.go:83:16: undefined: unsafe.Slice
/home/christianc/go/pkg/mod/golang.org/x/sys@v0.0.0-20220919091848-fb04ddd9f9c8/unix/syscall_unix.go:118:7: undefined: unsafe.Slice
/home/christianc/go/pkg/mod/golang.org/x/sys@v0.0.0-20220919091848-fb04ddd9f9c8/unix/sysvshm_unix.go:33:7: undefined: unsafe.Slice
note: module requires Go 1.17
# sigs.k8s.io/release-utils/version
/home/christianc/go/pkg/mod/sigs.k8s.io/release-utils@v0.7.3/version/version.go:122:25: bi.Settings undefined (type *debug.BuildInfo has no field or method Settings)
note: module requires Go 1.18
# sigs.k8s.io/json/internal/golang/encoding/json
/home/christianc/go/pkg/mod/sigs.k8s.io/json@v0.0.0-20211208200746-9f7c6b3444d2/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
/home/christianc/go/pkg/mod/sigs.k8s.io/json@v0.0.0-20211208200746-9f7c6b3444d2/internal/golang/encoding/json/encode.go:1255:18: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
note: module requires Go 1.17
make: *** [Makefile:176: docgen] Fehler 2

Feel free to modify this PR or do the change yourself. I don't think this tiny change is worth investing hours for me to debug this :)

@cpanato
Copy link
Member

cpanato commented Oct 5, 2022

@ChristianCiach if you dont mind i can push the change for this, let me know if you are ok with that

@ChristianCiach
Copy link
Contributor Author

@cpanato Yes, thank you! Feel free to do that.

znewman01
znewman01 previously approved these changes Oct 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #2306 (2d6719a) into main (58e0c0f) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2306   +/-   ##
=======================================
  Coverage   30.06%   30.06%           
=======================================
  Files         131      131           
  Lines        8062     8062           
=======================================
  Hits         2424     2424           
  Misses       5314     5314           
  Partials      324      324           
Impacted Files Coverage Δ
cmd/cosign/cli/options/verify.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cpanato
Copy link
Member

cpanato commented Oct 5, 2022

this will fix the lint error #2314

ChristianCiach and others added 2 commits October 5, 2022 13:26
Signed-off-by: ChristianCiach <christian.ciach@emsysgrid.de>
Signed-off-by: cpanato <ctadeu@gmail.com>
@priyawadhwa priyawadhwa merged commit 1b498c0 into sigstore:main Oct 7, 2022
@github-actions github-actions bot added this to the v1.14.0 milestone Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants