Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default target peer for proposer-only mode for PeerDAS. #6164

Open
wants to merge 1 commit into
base: das
Choose a base branch
from

Conversation

jimmygchen
Copy link
Member

Issue Addressed

The default target peer for proposer node (=15) will need to be increased for peerdas. A node would need peers across all data column subnets to be able to publish the data columns successfully.

If we can have "decentralized blob building" working reliably on PeerDAS in the future, then proposers won't necessary need to publish blobs themselves and this number can potentially be reduced again.

@jimmygchen jimmygchen added ready-for-review The code is ready for review das Data Availability Sampling labels Jul 24, 2024
@mergify mergify bot deleted the branch sigp:das August 27, 2024 04:10
@mergify mergify bot closed this Aug 27, 2024
@michaelsproul michaelsproul reopened this Aug 27, 2024
@michaelsproul
Copy link
Member

Please update to point at unstable by either:

  1. Rebasing on unstable (if your branch has a small number of commits that are easy to tease out), or
  2. Merging origin/das into this PR: git fetch origin; git merge origin/das. This will result in the smallest number of conflict resolutions and is better for branches that already contain merge commits or have extensive history.

@jimmygchen jimmygchen added do-not-merge and removed ready-for-review The code is ready for review labels Aug 28, 2024
@jimmygchen
Copy link
Member Author

This feature makes the proposer-only mode less useful than it was. I'm inclined to see whether decentralized blob building #6268 formally make it into the spec before deciding to merge this one.

IMO I think we should ship peerdas with #6268, and we'd be able to keep the proposer-only feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling do-not-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants