chore: fix pr comments #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimoo
reviewed
Feb 14, 2024
| impl Compliance { | ||
| const BTC_ID: &'static str = "344"; | ||
| const TICK_INTERVAL: u64 = 600; |
There was a problem hiding this comment.
so every 10min, maybe we can relax this even more... mmm... I think it'd be a good idea to log it when we detect an update on the sanction list, so that we can have an idea of the frequency and revise this number later
There was a problem hiding this comment.
The good thing is that there is pre-fetch stage which will fetch a few bytes initially. Those few bytes are enough to see if there is a fresh version of the dataset. Basically, the XML includes a tag that has the publish date of the document. So if the there is no fresh data then we don't fetch and parse the large XML file. This takes a few milliseconds to run.
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes comments in this PR #30