Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/input): remove hover state from readonly and disabled variant #1476

Merged
merged 8 commits into from
Sep 24, 2024

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Sep 16, 2024

💡 What is the current behavior?

GitHub Issue Number: Closes #1458, [IX-1655]

🆕 What is the new behavior?

  • no hover state on readonly
  • no hover state on disabled

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 846b29f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS class read-only is not affected by this change (<input class"read-only"..)

Copy link

sonarcloud bot commented Sep 24, 2024

@danielleroux danielleroux merged commit 7f37165 into main Sep 24, 2024
14 checks passed
@danielleroux danielleroux deleted the fix/1655-input branch September 24, 2024 14:54
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong states for read-only and disabled: Input field
3 participants