Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to remove stream and query callback dynamically. #1594

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

suhothayan
Copy link
Contributor

Purpose

Fixes #1590

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@43b2db4). Click here to learn what that means.
The diff coverage is 76.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1594   +/-   ##
=========================================
  Coverage          ?   67.74%           
  Complexity        ?       45           
=========================================
  Files             ?      651           
  Lines             ?    27522           
  Branches          ?     4339           
=========================================
  Hits              ?    18644           
  Misses            ?     7061           
  Partials          ?     1817
Impacted Files Coverage Δ Complexity Δ
...ain/java/io/siddhi/core/stream/StreamJunction.java 68.28% <100%> (ø) 0 <0> (?)
...in/java/io/siddhi/core/query/QueryRuntimeImpl.java 91.8% <100%> (ø) 0 <0> (?)
...ddhi/core/query/output/callback/QueryCallback.java 100% <100%> (ø) 0 <0> (?)
...main/java/io/siddhi/core/SiddhiAppRuntimeImpl.java 63% <60%> (ø) 0 <0> (?)
...core/query/output/ratelimit/OutputRateLimiter.java 91.93% <83.33%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b2db4...3f544f6. Read the comment docs.

@pcnfernando pcnfernando merged commit fdce7f8 into siddhi-io:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants