Handle empty item.route in FolderImpl #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d indexable by search engines by default (shuding#2829) * add * Make the `<Tab />` component be crawlable and indexable by search engines by default
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ul />` lists (shuding#2969) * fix * prettier * use pnpm/action-setup@v4
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…tton prevents scrolling to most top (shuding#2981) aa
* update prettier * update pnpm
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* update eslint deps * aa * prettier
…ment inside (shuding#2987) * aa * aa * aa * changeset * prettier * aa * prettier * rollback * rollback * aa * prettier * aa
* Fix the line-numbers style in syntax highlighting * Update .changeset/warm-cameras-vanish.md --------- Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
* Omit `...{:type}` annotations from search index
* Prettier
* Lint
* Update packages/nextra/src/server/remark-plugins/remark-structurize.ts
Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
* Lint
* polish
---------
Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(deps): update dependency katex to v0.16.10 [security] * fix types check --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ing#3297) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* [v3] update the back-to-top option to support i18n * fix eslint sort-keys warning * avoid displaying undefined as text * keep `loading`, `placeholder` and `themeSwitch.useOptions` default theme options only for `en` lang * keep it simpler * lint * prettier --------- Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Added typescript documentation * upd --------- Co-authored-by: Nicolas Javkin <nicolas@hellohive.com> Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
* Add ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE Add ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE to the .github directory. These templates are designed to assist contributors in reporting issues and submitting pull requests by providing guidance on the necessary information to include. This helps streamline the contribution process for both issue reporting and pull requests. * prettier --------- Co-authored-by: Fun117 <fun117.kun@gmail.com> Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
* Update steps.mdx Update the docs about the <Steps /> component with the information on how to exclude the headings from ToC. * Update docs/pages/docs/guide/built-ins/steps.mdx * Update docs/pages/docs/guide/built-ins/steps.mdx * polish * prettier * Update docs/pages/docs/guide/built-ins/steps.mdx --------- Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
* Created cards.mdx New docs page for the Docs Theme on the Cards component * fix * prettier * more * more * more * more --------- Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
* Update i18n.mdx The i18n new format is working good! * add note --------- Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
* Update start.mdx - static exports added documentation on how to statically deploy the documentation, and how to edit the next.config.js * more * more * more --------- Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
* polish * polish custom theme * more * more * more * more * more * more * more * more * more * polish * more * more * Update docs/pages/docs/docs-theme.mdx * more * more * pre exit
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 99f7697 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@hasparus is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
dimaMachina
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋
Why:
This fixes the problem where a top level folder in sidebar without its own route is always open, despite the fact that it has a
pointercursor and it seems like it should be collapsible.You can see it on https://the-guild.dev/.
Screen.Recording.2024-09-30.at.12.44.14.mov
What's being changed (if available, include any code snippets, screenshots, or gifs):
I prefixed the checks for for
includesandstartsWitchthat compute the active route state with checking if theitem.routeis empty.Check off the following:
I have reviewed my changes in staging, available via the View
deployment link in this PR's timeline (this link will be available after
opening the PR).
with links directly to pages you've modified. The comment won't appear if
your PR only edits files in the
datadirectory.For content changes, I have completed the
self-review checklist.